Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bundler 2.4 blog post and release notes #978

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Add Bundler 2.4 blog post and release notes #978

merged 2 commits into from
Jan 31, 2023

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user problem that led to this PR?

The problem was the we should announce the upcoming Bundler 2.4 release.

What is your fix for the problem, implemented in this PR?

My fix is to draft a release blog post and a "What's new" page.

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--3ntxvk December 22, 2022 12:36 Inactive
olleolleolle
olleolleolle reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this nice post!

source/blog/2022-12-22-bundler-v2-4.html.markdown Outdated Show resolved Hide resolved
source/blog/2022-12-22-bundler-v2-4.html.markdown Outdated Show resolved Hide resolved
source/blog/2022-12-22-bundler-v2-4.html.markdown Outdated Show resolved Hide resolved
source/blog/2022-12-22-bundler-v2-4.html.markdown Outdated Show resolved Hide resolved
source/blog/2022-12-22-bundler-v2-4.html.markdown Outdated Show resolved Hide resolved
source/blog/2022-12-22-bundler-v2-4.html.markdown Outdated Show resolved Hide resolved
source/blog/2022-12-22-bundler-v2-4.html.markdown Outdated Show resolved Hide resolved
source/blog/2022-12-22-bundler-v2-4.html.markdown Outdated Show resolved Hide resolved
source/blog/2022-12-22-bundler-v2-4.html.markdown Outdated Show resolved Hide resolved
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--petrjx December 22, 2022 13:15 Inactive
@deivid-rodriguez
Copy link
Member Author

Thanks so much for copy editing! ❤️

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 22, 2022 14:10 Inactive
olleolleolle
olleolleolle reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I found a small thing.

source/v2.4/whats_new.html.haml Outdated Show resolved Hide resolved
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 22, 2022 14:32 Inactive
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 22, 2022 14:39 Inactive
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 22, 2022 14:39 Inactive
@olleolleolle
Copy link
Member

🏆 Yes!!!

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 22, 2022 14:49 Inactive
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 22, 2022 15:04 Inactive
@deivid-rodriguez
Copy link
Member Author

Blog post draft is here: https://bundler-site-bundler-2--j2zpxa.herokuapp.com/blog/2022/12/22/bundler-v2-4.html

I left the section about gems with Rust extensions empty because I think @simi wanted to write about this.

What's new page is here: https://bundler-site-bundler-2--j2zpxa.herokuapp.com/v2.4/whats_new.html.

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 22, 2022 16:18 Inactive
@deivid-rodriguez
Copy link
Member Author

I moved additional changes to other PRs to make reviewing this one easier.

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 22, 2022 16:46 Inactive
@simi
Copy link
Member

simi commented Dec 24, 2022

Blog post draft is here: https://bundler-site-bundler-2--j2zpxa.herokuapp.com/blog/2022/12/22/bundler-v2-4.html

I left the section about gems with Rust extensions empty because I think @simi wanted to write about this.

What's new page is here: https://bundler-site-bundler-2--j2zpxa.herokuapp.com/v2.4/whats_new.html.

I have prepared initial version at #982.

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 24, 2022 06:38 Inactive
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 24, 2022 06:43 Inactive
@deivid-rodriguez deivid-rodriguez mentioned this pull request Dec 24, 2022
Closed
@deivid-rodriguez deivid-rodriguez changed the title Draft Bundler 2.4 blog post and release notes Add Bundler 2.4 blog post and release notes Dec 25, 2022
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 25, 2022 17:39 Inactive
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 25, 2022 17:40 Inactive
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--j2zpxa December 25, 2022 17:55 Inactive
@tnir
Copy link
Collaborator

tnir commented Dec 29, 2022

@deivid-rodriguez What is the blocker for merging this?

@deivid-rodriguez
Copy link
Member Author

I'm finishing up a fix to bundle lock --update --bundler command, which is currently advertised in the blog post.

I want it to work fine before we publish the post, but if we are willing to publish this right now, I can edit the blog post to remove the mention to it and publish it.

@tnir
Copy link
Collaborator

tnir commented Dec 29, 2022

Thanks @deivid-rodriguez. If you do not want to publish this blog post, I am still inclined to publish Bundler v2.4-based docs (https://bundler.io/v2.4/docs.html) as soon as possible. To do so, we can create another PR from this but without changes in /source/blog. What do you think?

@deivid-rodriguez
Copy link
Member Author

Sounds good, let me extract a separate PR!

@deivid-rodriguez deivid-rodriguez mentioned this pull request Dec 29, 2022
Merged
@deivid-rodriguez
Copy link
Member Author

I extracted #991.

@tnir tnir added this to the Bundler 2.4 milestone Dec 29, 2022
@tnir
Copy link
Collaborator

tnir commented Jan 2, 2023

#1051 might be relevant to this once it is merged.

@indirect indirect temporarily deployed to bundler-site-bundler-2--odqbld January 4, 2023 10:51 Inactive
@indirect indirect mentioned this pull request Jan 4, 2023
Closed
simi and others added 2 commits January 31, 2023 15:42
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--or7xjx January 31, 2023 15:05 Inactive
@deivid-rodriguez
Copy link
Member Author

Preview looks good, so let's publish this!

@deivid-rodriguez deivid-rodriguez merged commit 309cad9 into master Jan 31, 2023
@deivid-rodriguez deivid-rodriguez deleted the bundler-2-4-docs branch January 31, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnir tnir tnir left review comments

@olleolleolle olleolleolle olleolleolle left review comments

@simi simi simi approved these changes

Assignees

@deivid-rodriguez deivid-rodriguez

Labels
None yet
Projects
None yet
Milestone
Bundler 2.4
Development

Successfully merging this pull request may close these issues.
5 participants
@deivid-rodriguez @olleolleolle @simi @tnir @indirect